Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella] test improvement #186

Open
8 of 15 tasks
himself65 opened this issue Nov 27, 2023 · 3 comments
Open
8 of 15 tasks

[Umbrella] test improvement #186

himself65 opened this issue Nov 27, 2023 · 3 comments
Assignees
@himself65
Labels
help wanted Extra attention is needed

Comments

@himself65
Copy link
Contributor

himself65 commented Nov 27, 2023 •
edited
Loading

This is a list of what kinds of tests we still need. In case of the regression:

Smoke test

E2E

  • Basic usage (click button, async server component)

SSR

  • Should ssr render correctly on the first screen

RSC

  • Should RSC work well
  • Should server action work well
  • Should server action interactive work well with local files
  • Dev mode should be the same as Prod mode.

Styles #265

  • css modules
  • vanilla-extract
  • stylex

Ecosystem

  • RSC with CSS
  • RSC with some vite plugins like (alias, vanilla extract CSS...)

Unit Test

  • Each single plugin should work well
  • RSC render worker should be predictable for each input/output (we don't have worker now)
@dai-shi dai-shi mentioned this issue Nov 28, 2023
Merged
@himself65
Copy link
Contributor Author

Other cases

  • multiple page application test (RSC / SSR)

@dai-shi dai-shi mentioned this issue Dec 14, 2023
Closed
@himself65
Copy link
Contributor Author

How do we test the serverless function like vercel, cloudflare, deno?

@himself65
Copy link
Contributor Author

I think we can test deno and cloudflare, but not vercel. Vercel requires us to build the code in production so we can test it?

@negreirosleo negreirosleo mentioned this issue May 3, 2024
Merged
dai-shi added a commit that referenced this issue May 4, 2024
@negreirosleo @dai-shi
test: add e2e tests for css modules (#693)
c41ef0c 
This PR relates to #186. It adds e2e tests for CSS modules.
I used `expect .toContain('class-name')` because I was not sure if the
generated name would always be the same.

---------

Co-authored-by: ¨Leonardo <¨[email protected]¨>
Co-authored-by: Daishi Kato <[email protected]>
@dai-shi dai-shi added the help wanted Extra attention is needed label Aug 30, 2024
@dai-shi dai-shi changed the title test improvement [Umbrella] test improvement Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himself65 himself65

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dai-shi @himself65