You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Start the Tutorial and advance to Tutorial Step 2 on mobile.
Can be reproduced using the device toolbar in Chrome Dev Tools.
Current Behavior
The condition specifying all the tutorial steps in which the GestureDiagram should be rendered is defined in /src/components/Tutorial/index.tsx, separately from the tutorial step components:
: null)||null)asGesturePath|null,// Why does it add 'string' to the type union without this?
)
Expected Behavior
The GestureDiagram condition for each tutorial step should be co-located within the tutorial step component itself. The tutorial index can therefore stay more agnostic towards the individual tutorial steps.
Note that the GestureDiagram needs to be rendered below the .tutorial element, whose height depends on the screen size of the device. The tutorial step component just contains the content of the tutorial step, not the paginator or Next/Prev buttons. You will need to do some refactoring to render the GestureDiagram in the right place while ensuring the condition is co-located in the tutorial step component.
The text was updated successfully, but these errors were encountered:
Steps to Reproduce
Start the Tutorial and advance to Tutorial Step 2 on mobile.
Can be reproduced using the device toolbar in Chrome Dev Tools.
Current Behavior
The condition specifying all the tutorial steps in which the GestureDiagram should be rendered is defined in
/src/components/Tutorial/index.tsx
, separately from the tutorial step components:em/src/components/Tutorial/index.tsx
Lines 91 to 107 in a674674
Expected Behavior
The GestureDiagram condition for each tutorial step should be co-located within the tutorial step component itself. The tutorial index can therefore stay more agnostic towards the individual tutorial steps.
Note that the GestureDiagram needs to be rendered below the
.tutorial
element, whose height depends on the screen size of the device. The tutorial step component just contains the content of the tutorial step, not the paginator or Next/Prev buttons. You will need to do some refactoring to render the GestureDiagram in the right place while ensuring the condition is co-located in the tutorial step component.The text was updated successfully, but these errors were encountered: