Potential breakage #72
Comments
NoahTheDuke
added a commit
to NoahTheDuke/potemkin
that referenced
this issue
Sep 15, 2023
If a var has tag metadata attached to the var symbol (not on the vector, as is the preferred method for return types in functions), it will be resolved when `import-*` is called during read time. This currently doesn't break anything, but if the proposed Clojure patch for [CLJ-1929][CLJ-1929] is accepted, then code that's so tagged will break. Includes a test that will break without the associated change if the Clojure patch is accepted. Closes [clj-commons#72][clj-commons#72] [CLJ-1929]: https://clojure.atlassian.net/browse/CLJ-1929 [clj-commons#72]: clj-commons#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Setup
CLJ-1929: "Literal collections are tagged as IPersistentVector, IPersistentMap, etc and as constant expressions won’t preserve type hints. If these collections are then used in a Java interop call, there is no way to indicate the desired type to choose a method overload between Collection and some other type."
This ticket has a patch that is on the shortlist for inclusion to 1.12.
Issue
As I commented in the issue, the strict version of the patch breaks Potemkin's
import-*macros. Given Potemkin's prominence within the community, it seems reasonable to me to proactively fix the issue.The text was updated successfully, but these errors were encountered: