Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"minor fourth" and "minor fifth" #92

Open
hesyifei opened this issue Jan 31, 2022 · 0 comments
Open

"minor fourth" and "minor fifth" #92

hesyifei opened this issue Jan 31, 2022 · 0 comments

Comments

@hesyifei
Copy link

hesyifei commented Jan 31, 2022

If I'm not mistaken, "minor fifth" and "minor fourth" do not exist. However, mingus seems to have both "minor fifth" and "diminished fifth" (and "minor fourth" and "diminished fourth") and treat them differently.

For example, Ab -> Ebb should have been a diminished fifth (and I don't know if there's any name for Ab -> Ebbb).

>>> intervals.determine("Ab", "Ebb")
'minor fifth'
>>> intervals.determine("Ab", "Ebbb")
'diminished fifth'

and C -> Fb should have been a diminished fourth

>>> intervals.determine("C", "Fb")
'minor fourth'
>>> intervals.determine("C", "Fbb")
'diminished fourth'

The same problem goes for the from_shorthand function:

>>> intervals.from_shorthand("C", "bb4")
'Fbb'

I would have expected this to return 'Fb' since the doc says "‘bb’ the diminished".

It would be great if this could be fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant