Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling GPS with MSP protocol is confusing #3572

Open
ws998116 opened this issue Sep 8, 2023 · 9 comments
Open

Enabling GPS with MSP protocol is confusing #3572

ws998116 opened this issue Sep 8, 2023 · 9 comments

Comments

@ws998116
Copy link

ws998116 commented Sep 8, 2023

Describe the bug

Using nightly version (10.10.0-debug-ff4b62d) of configurator!

To enable GPS with MSP protocol, it takes the following steps.

  1. Configure port as MSP. Save and Reboot
  2. Enable GPS in Configuration Tab, go to GPS tab and switch protocol to MSP. Save and Reboot.
  3. Enable GPS in Configuration Tab again. Save and Reboot.

If you do not switch the protocol before rebooting the second time, you will not be able to enable GPS because there is not a serial port configured for GPS.

To Reproduce

  1. Configure port as MSP. Save and Reboot
  2. Enable GPS in Configuration Tab. Save and Reboot.
  3. GPS tab is not available.

Expected behavior

  1. Configure port as MSP. Save and Reboot
  2. Enable GPS with MSP protocol in Configuration Tab. Save and Reboot.
  3. View data in GPS tab.

Configurator version

10.10.0-debug-ff4b62d

Flight controller configuration

No response

Add any other context about the problem that you think might be relevant here

Testing with HOBBYWING_XROTORF7CONV

@haslinghuis
Copy link
Member

Did you try to enable MSP and GPS at the same time (as it should enable feature GPS automatically)?
Which GPS is being used?

@ws998116
Copy link
Author

Enabling a port as MSP does not seem to enable GPS automatically. I cannot enable both at the same time because if I leave the Ports tab then the settings are not saved. Configuring the GPS protocol as MSP does not automatically enable GPS.

I am using the Flite Test EZ ID (Remote ID Broadcast Module) connected over UART 1.

The required settings are as follows. It is possible to configure it this way, but it is difficult to do because the GPS protocol configuration is on a different tab than enabling GPS.

image

image

image

@haslinghuis
Copy link
Member

  • Enable MSP and GPS at the same time (as it should enable feature GPS automatically) on ports tab.
  • Notice GPS is automatically enabled on configuration tab.
  • Select MSP on GPS tab. We could look into eliminating this last step.

@nerdCopter
Copy link
Member

  • Enable MSP and GPS at the same time [...]

what is the requirement for this? on master, if i enable both (ports tab uart3), save&reboot. neither save. (i can save one or the other, but not both)

@ws998116
Copy link
Author

Sorry @haslinghuis, I still cannot replicate your steps. I have the same issue as @nerdCopter.

betaflight

@haslinghuis
Copy link
Member

haslinghuis commented Sep 11, 2023

Unless I need a MSP enabled GPS I'm not able to save MSP on the ports tab UART associated with GPS (even when allowing with port function sharing rules after minor modification in configurator).

Cannot test if GPS works with MSP while just choosing the protocol used on GPS tab.

@ctzsnooze
Copy link
Member

It is important to never enable GPS on a serial port if you are connecting your GPS over MSP.

@betaflight betaflight deleted a comment Jan 6, 2024
@rcocker99
Copy link

rcocker99 commented May 24, 2024

@ws998116 Can I consider the directions at the very beginning of this post to be a useable workaround to get GPS working over MSP? I'm struggling with the same issue with a Phoenix remote ID GPS passthrough that uses MSP and I can't bear to put more time into it unless I'm confident it'll work. No worries if it's not a workaround, any clarification is great. Thanks!

To enable GPS with MSP protocol, it takes the following steps.

Configure port as MSP. Save and Reboot
Enable GPS in Configuration Tab, go to GPS tab and switch protocol to MSP. Save and Reboot.
Enable GPS in Configuration Tab again. Save and Reboot.
If you do not switch the protocol before rebooting the second time, you will not be able to enable GPS because there is not a serial port configured for GPS.

@AZDane
Copy link

AZDane commented May 27, 2024

@ws998116 Can I consider the directions at the very beginning of this post to be a useable workaround to get GPS working over MSP? I'm struggling with the same issue with a Phoenix remote ID GPS passthrough that uses MSP and I can't bear to put more time into it unless I'm confident it'll work. No worries if it's not a workaround, any clarification is great. Thanks!

To enable GPS with MSP protocol, it takes the following steps.
Configure port as MSP. Save and Reboot
Enable GPS in Configuration Tab, go to GPS tab and switch protocol to MSP. Save and Reboot.
Enable GPS in Configuration Tab again. Save and Reboot.
If you do not switch the protocol before rebooting the second time, you will not be able to enable GPS because there is not a serial port configured for GPS.

I had to do something to that extent when I set up my Phoenix remote ID module. Make sure to Save a Backup before you begin because if you end up doing it in the wrong order, I have seen it clear all your ports. During testing I have switched a lot between directly connected GPS/UBLOX and connected via Phoenixuas/MSP and because it is a little buggy, I just restore backups since its easier. Everytime you change, you also have to reenable GPS rescue under failsafe and reenable GPS Rescue switch in modes etc.
Also, if you plan on using GPS Rescue over MSP make sure you are on 4.5.1 Dev since it has a bugfix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants