Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Token validation in middleware #516

Open
cyruxOP opened this issue Sep 4, 2024 · 3 comments
Open

[BUG] Token validation in middleware #516

cyruxOP opened this issue Sep 4, 2024 · 3 comments
Labels
needs-info Need more information such as reproduction step stale Issue labeled as stale will be closed automatically

Comments

@cyruxOP
Copy link

cyruxOP commented Sep 4, 2024

Describe the bug
The middleware function while calling get_current_user is not catching any errors returned by get_current_user function.

To Reproduce
Go to bedrock-claude-chat/backend/app/main.py
Line 94 middleware function . And in the same parent folder dependencies.py when it raises error it is not being handled in the main.py middleware function. Which would lead to errors and multiple invocations.

Ideally when something fails we should return from middleware only without processing further.

@cyruxOP cyruxOP changed the title [BUG] [BUG] Token validation in middlware Sep 4, 2024
@cyruxOP cyruxOP changed the title [BUG] Token validation in middlware [BUG] Token validation in middleware Sep 4, 2024
@statefb
Copy link
Contributor

statefb commented Sep 5, 2024

Please do not ignore the template and provide details. thank you

@statefb statefb added the needs-info Need more information such as reproduction step label Sep 5, 2024
@cyruxOP
Copy link
Author

cyruxOP commented Sep 5, 2024

@statefb Added more details

@github-actions github-actions bot added the stale Issue labeled as stale will be closed automatically label Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 14 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Need more information such as reproduction step stale Issue labeled as stale will be closed automatically
Projects
None yet
Development

No branches or pull requests

2 participants