Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parameterized GlobalRuleDefinitionExecutorAssert to instead of GlobalRuleDefinitionExecutorTest #33151

Open
terrymanu opened this issue Oct 8, 2024 · 3 comments
Open

Use parameterized GlobalRuleDefinitionExecutorAssert to instead of GlobalRuleDefinitionExecutorTest #33151

terrymanu opened this issue Oct 8, 2024 · 3 comments
Assignees
@karthikkurella
Labels
feature: DistSQL good first issue in: test status: volunteer wanted
Milestone
5.5.2

Comments

@terrymanu
Copy link
Member

Use DistSQLRuleDefinitionExecutorTestCaseArgumentsProvider and XML to simplify DistSQL test cases.

Ref DistSQLGlobalRuleQueryExecutorAssert
@terrymanu terrymanu added this to the 5.5.1 milestone Oct 8, 2024
@terrymanu terrymanu changed the title Use parameterized GlobalRuleDefinitionExecutorTAssert to instead of GlobalRuleDefinitionExecutorTest Use parameterized GlobalRuleDefinitionExecutorAssert to instead of GlobalRuleDefinitionExecutorTest Oct 8, 2024
@karthikkurella
Copy link

@terrymanu , could you please assign this task to me? thanks. I can raise a PR for review

@strongduanmu
Copy link
Member

@karthikkurella Assigned.

@taojintianxia taojintianxia modified the milestones: 5.5.1, 5.5.2 Oct 11, 2024
@ogprakash
Copy link

@terrymanu can i also work on this please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikkurella karthikkurella

Labels
feature: DistSQL good first issue in: test status: volunteer wanted
Projects
None yet
Milestone
5.5.2
Development

No branches or pull requests
5 participants
@taojintianxia @terrymanu @strongduanmu @karthikkurella @ogprakash