Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise and remove usages of make_function_scalar_inputs, make_function_scalar_inputs_return_type, make_function_inputs2 #12923

Open
findepi opened this issue Oct 14, 2024 · 1 comment · May be fixed by #12972
Open

Revise and remove usages of make_function_scalar_inputs, make_function_scalar_inputs_return_type, make_function_inputs2 #12923

findepi opened this issue Oct 14, 2024 · 1 comment · May be fixed by #12972
Assignees
@buraksenn

Comments

@findepi
Copy link
Member

findepi commented Oct 14, 2024 •
edited
Loading

In #12881, #12890 it turned out that make_function_scalar_inputs_return_type may lead to less performant code.

In #12909 it turned out that make_function_inputs2 may lead to less performant code.

Revise remaining usages and improve. See above PRs for guidance.
@findepi findepi mentioned this issue Oct 14, 2024
Merged
@buraksenn
Copy link

take

@findepi findepi mentioned this issue Oct 15, 2024
Merged
@findepi findepi changed the title Revise and remove usages of make_function_scalar_inputs_return_type Revise and remove usages of make_function_scalar_inputs, make_function_scalar_inputs_return_type, make_function_inputs2 Oct 15, 2024
@findepi findepi mentioned this issue Oct 15, 2024
Merged
@buraksenn buraksenn linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buraksenn buraksenn

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@findepi @buraksenn