Make mentioned changes in resources files to follow the same convention

[PrashanthPuneriya]

Description

As a contributor,
I need consistent style followed in resources file,
so that I don't get confused that whether some part of the code is missing or not.

Mocks

mentorship-backend/app/api/resources/user.py

Lines 171 to 182 in 6fe6929

	@users_ns.response(HTTPStatus.CREATED, "%s" % messages.PASSWORD_SUCCESSFULLY_UPDATED)
	@users_ns.response(HTTPStatus.BAD_REQUEST, "%s" % messages.USER_ENTERED_INCORRECT_PASSWORD)
	@users_ns.response(
	HTTPStatus.UNAUTHORIZED,
	"%s\n%s\n%s"
	% (
	messages.TOKEN_HAS_EXPIRED,
	messages.TOKEN_IS_INVALID,
	messages.AUTHORISATION_TOKEN_IS_MISSING,
	),
	)
	@users_ns.route("user/change_password")

Here the route is below the responses which breaks the convention.

mentorship-backend/app/api/resources/user.py

Lines 247 to 268 in 6fe6929

	@users_ns.route("register")
	class UserRegister(Resource):
	@classmethod
	@users_ns.doc("create_user")
	@users_ns.response(HTTPStatus.CREATED, "%s" % messages.USER_WAS_CREATED_SUCCESSFULLY)
	@users_ns.response(
	HTTPStatus.BAD_REQUEST,
	"%s\n%s\n%s"
	% (
	messages.USERNAME_FIELD_IS_EMPTY,
	messages.PASSWORD_INPUT_BY_USER_HAS_INVALID_LENGTH,
	messages.EMAIL_INPUT_BY_USER_IS_INVALID
	),
	)
	@users_ns.response(
	HTTPStatus.CONFLICT,
	"%s\n%s"
	% (
	messages.USER_USES_A_USERNAME_THAT_ALREADY_EXISTS,
	messages.USER_USES_AN_EMAIL_ID_THAT_ALREADY_EXISTS
	),
	)

Here the responses aren't attached with the route function but with the put().

Acceptance Criteria

Update [Required]

• Make the above mentioned changes in the code to follow the same convention throughout the file.
• Check the same with other resources files and fix them if such convetion is broken.

Definition of Done

• All of the required items are completed.
• Approval by 1 mentor.

Estimation

4 hours

[gitpurva]

Can I take up this issue?

[PrashanthPuneriya]

Sure @gitpurva

[PrashanthPuneriya]

Any progress @gitpurva?

[gitpurva]

I will submit the PR by tomorrow.

…

On Mon, Sep 28, 2020, 7:55 PM Prashanth Puneriya ***@***.***> wrote: Any progress @gitpurva <https://github.com/gitpurva>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#898 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKVEGYCVQCYSBKKTGCXH2LSICMGZANCNFSM4R25DNAA> .

[devkapilbansal]

@isabelcosta putting this on hold as what needs to be done not seems to be clearly mentioned in this issue.