Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS scriptable objects are not properly overriding property attribute resolution #19

Open
pavelhoral opened this issue Aug 7, 2024 · 1 comment

Comments

@pavelhoral
Copy link
Member

This is related to mozilla/rhino#1558. I think we need to update our scriptable objects to implement IdScriptableObject#findInstanceIdInfo to have a working property attribute resolution (otherwise features like Object.assign won't work correctly).

@pavelhoral
Copy link
Member Author

pavelhoral commented Aug 19, 2024

After some investigation the findInstanceIdInfo is probably not the solution nor the workaround we want. We should avoid using Object.assign in our scripts (and use lodash's _.assign) until we have a proper solution.

I would love to drop our custom ScriptableMap implementation and replace it with Rhino's NativaJavaMap. Unfortunately they are not compatible due to c094dcb which is a commit I am yet to fully understand 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant