Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ten-year challenge: Reproduction of An allosteric model of calmodulin [PNAS 105(31), 10768 (2008)] #38

Open
MelanieIStefan opened this issue May 1, 2020 · 13 comments

Comments

@MelanieIStefan
Copy link

Original article: M.I. Stefan, S.J. Edelstein, N. Le Novère (2008). An allosteric model of calmodulin explains differential activation of PP2B and CaMKII. PNAS 105(31), 10768.

PDF URL: https://github.com/MelanieIStefan/calmodulin_reproduction/blob/master/ReScience_Calmodulin.pdf
Metadata URL:
Code URL: https://github.com/MelanieIStefan/calmodulin_reproduction

Scientific domain: Systems neuroscience
Programming language: SBML, R
Suggested editor: This is part of the 10-year challenge, so should be handled by the challenge organisers

@MelanieIStefan MelanieIStefan changed the title Reproduction of An allosteric model of calmodulin [PNAS 105(31), 10768 (2008)] Ten-year challenge: Reproduction of An allosteric model of calmodulin [PNAS 105(31), 10768 (2008)] May 1, 2020
@rougier rougier self-assigned this May 4, 2020
@rougier
Copy link
Member

rougier commented May 4, 2020

Thanks for your submission, I will edit it.

@apdavison Could you review this submission for the Ten Years Reproducibility Challenge?

@apdavison
Copy link

yes, I can review it

@rougier
Copy link
Member

rougier commented May 5, 2020

@apdavison Wonderful, thanks. No hard deadline for the review but the sooner the better...

@rougier
Copy link
Member

rougier commented Jun 15, 2020

@apdavison Gentle reminder

@apdavison
Copy link

Hi @MelanieIStefan I'm struggling a bit with this, as I haven't used Copasi before. I've got as far as loading "Figure3.cps" and running a parameter scan, but I can't figure out how to save the results (i.e. to try to recreate Figure3.txt). Please can you help me out with a detailed description of what to click on/select?

@MelanieIStefan
Copy link
Author

Hi @apdavison - when you run the parameter scan, a separate window should be created by Copasi where the results are plotted. In that window, you can select "Save Data" from the menu above the plot.

Save

This should bring up a menu allowing you to save the data as a .txt file. Please let me know if this doesn't work.

@apdavison
Copy link

This is a well-written article, which serves as an excellent example of why reproducibility of modelling studies requires not only the model specification but also the simulation configuration and data analysis scripts to be stored.

I was able to re-run the simulations, and reproduce the data files in the repository.

Major issues:

  • the curves in the manuscript differ substantially from those in the corrections to the original manuscript. The following two graphs compare the curves digitised from the corrected Figure 3 and 4 in Stefan et al. 2008 with the data from the reproduction.

comparison_figure3

comparison_figure4

On the basis of this, I don't think that the original parameters have been correctly recovered. I recommend an attempt is made to obtain a closer fit to the original curves (perhaps using automated parameter fitting). This might also result in a successful reproduction of Figure 5. Otherwise, I think this has to be labelled an unsuccessful reproduction and the manuscript amended accordingly.

Minor issues:

  • IUPAC recommendations are that the names of elements should not be capitalised, so "Calcium" should be replaced by "calcium" (as in the original article that is being reproduced).
  • "an attempt to reproduce the code" should be something like "an attempt to reproduce the results using the original code"
  • "Calcium frequencies" - it is not clear what is meant here. Concentrations?

@MelanieIStefan
Copy link
Author

Thank you for your thoughtful comments!

@rougier
Copy link
Member

rougier commented Sep 8, 2020

@apdavison Thanks for the detailed review.
@MelanieIStefan Did you have time to address the comments ?

@rougier
Copy link
Member

rougier commented May 28, 2021

@MelanieIStefan Sorry for the delay. Did you have time to take comments into account?

@rougier
Copy link
Member

rougier commented May 24, 2022

@MelanieIStefan Should we close this submission?

@MelanieIStefan
Copy link
Author

Hello! Please don't close it just yet. I know it's been a while, but I would like a chance to figure this out please.

@rougier
Copy link
Member

rougier commented Dec 20, 2023

@MelanieIStefan Any update (after 1.5 years :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants