Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[主線] [PTT] 增加基本註解 #109

Open
3 of 5 tasks
y2468101216 opened this issue Mar 2, 2021 · 6 comments
Open
3 of 5 tasks

[主線] [PTT] 增加基本註解 #109

y2468101216 opened this issue Mar 2, 2021 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@y2468101216
Copy link
Collaborator

y2468101216 commented Mar 2, 2021

實作細節 / Details of Implement

現有大部分的 code 皆未有註解,須對 function 跟 test 增加註解

期程 / Schedule

  • 討論時間: 一天
  • 實作時間: 一天
  • 確認時間: 一天

相關文件 / Documents

實作中

相關項目 / Child Task

@y2468101216 y2468101216 added the help wanted Extra attention is needed label Mar 2, 2021
@PichuChen
Copy link
Member

這樣好像 ISSUE 會太大,如果先把需要註解的檔案都先表列出來讓每個檔案都分成子 ISSUE 下去處理呢?

@y2468101216
Copy link
Collaborator Author

要拆分,我還在整理,目前先開著方便我作整理

@PichuChen
Copy link
Member

應該可以把它拆成每個檔案一個項目然後讓大家認領,不過現在有些東西要先處理,主要是註解的格式還有需要註解的範圍,例如沒有 exported 的 method 需不需要註解

@PichuChen
Copy link
Member

然後需要在 ISSUE 的開頭有個註解的範例,這樣大家才知道要怎麼寫成相同的風格。

@y2468101216
Copy link
Collaborator Author

恩,所以我先弄了一個 pr 出來讓大家參考,等好了以後會指派子 issue 給大家

@PichuChen
Copy link
Member

這個 ISSUE 目前還有在更新嗎? 不然兩週後要把他先關掉了喔?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants