Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metro manila version #10

Open
benbancure94 opened this issue Apr 17, 2023 · 14 comments
Open

metro manila version #10

benbancure94 opened this issue Apr 17, 2023 · 14 comments
Labels
in review Issue label for in review issues tweak Issue label for tweaks

Comments

@benbancure94
Copy link

benbancure94 commented Apr 17, 2023

Good day!

I created my own version, but only for Metro Manila. This is not yet pushed into this repo.

phMap (6)

@warengonzaga
Copy link
Member

Amazing work @benbancure94 do you have the repo? or you want to add this as feature to the project?

@benbancure94
Copy link
Author

I downloaded a clone of this repository and modified in my local computer.

@warengonzaga
Copy link
Member

Cool, do you have plans to release it to the public or you want to add that as new feature for the project?

@benbancure94
Copy link
Author

benbancure94 commented Apr 17, 2023

Would you mind that I will release/deploy this to public myself but using the cloned code from your project?

@warengonzaga
Copy link
Member

Hmm, if you want to release it, feel free but please add credits to your readme linking back to this repository.

@warengonzaga warengonzaga changed the title New Feature: For Metro Manila metro manila version Apr 17, 2023
@benbancure94
Copy link
Author

Ok, sure .

@warengonzaga warengonzaga added in review Issue label for in review issues tweak Issue label for tweaks labels Apr 21, 2023
@loumexx
Copy link

loumexx commented Apr 22, 2023

This is awesome! I'm actually also making my own, pretty much serving as coding practice. Looking forward to when this gets released!

@benbancure94
Copy link
Author

Here is mine.

@jofftiquez
Copy link
Member

Here is mine.

Great work! Do you have plans on making a PR for this to the main repo?

@warengonzaga
Copy link
Member

same question @benbancure94 maybe we can add this to the main project.

@denzdelvillar
Copy link
Collaborator

I think our options are:

a) we can put a section Have You Tried: that lists down links to all other maps like @benbancure94's that was inspired by this project, or
b) integrate the new maps into the main project itself

I'm more inclined towards option a because it gives the other developers more freedom with their own maps without having to do a PR on this project when they change something.

@jofftiquez
Copy link
Member

I think our options are:

a) we can put a section Have You Tried: that lists down links to all other maps like @benbancure94's that was inspired by this project, or b) integrate the new maps into the main project itself

I'm more inclined towards option a because it gives the other developers more freedom with their own maps without having to do a PR on this project when they change something.

I agree. Our goal to highlight all projects as much as possible while maintaining collaboration at the same time. Kudos to you guys. It's still up to @benbancure94 let us know what you think.

Speaking of option a, @denzdelvillar maybe we can start updating the design of the about page? As suggested in #15 we need to put the map itself first, then additional details in other pages. For the idea of option a we can add a toolbar to the / page.

@warengonzaga
Copy link
Member

We can add a menu in the main web app for other versions, what do you folks think?

@warengonzaga
Copy link
Member

Are we still going to add this? I think we can look back at this again sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Issue label for in review issues tweak Issue label for tweaks
Projects
None yet
Development

No branches or pull requests

5 participants