Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated and vulnerable v8 is used #1664

Open
1 task done
kxxt opened this issue Aug 24, 2024 · 2 comments
Open
1 task done

Outdated and vulnerable v8 is used #1664

kxxt opened this issue Aug 24, 2024 · 2 comments
Assignees

Comments

@kxxt
Copy link

kxxt commented Aug 24, 2024

This issue is unique.

  • I have used the search tool and did not find an issue describing my idea.

Your idea.

The javascript engine v8, version 8.9(used in https://github.com/ONLYOFFICE/build_tools/blob/master/scripts/core_common/modules/v8_89.py) is very outdated and vulnerable.

It should be updated to a recent version or have security patches backported.

For reference, qt5-webengine uses chromium 87 and v8 8.7 with some added security patches. The commits are available here: https://github.com/qt/qtwebengine-chromium/commits/87-based/

@kxxt
Copy link
Author

kxxt commented Aug 31, 2024

The cef binary, downloaded from http://d2ettrnqo7v976.cloudfront.net/cef/5414/linux_64/cef_binary.7z in https://github.com/ONLYOFFICE/build_tools/blob/master/scripts/core_common/modules/cef.py also appears to be very outdated.

And seriously, why is it downloaded from an HTTP url without any checksumming?

@dbermond
Copy link

dbermond commented Sep 2, 2024

also appears to be very outdated.

The CEF used is branch 5414, which gives chromium version 109. Really outdated. Being CEF a core component of the user interface functionality, it's a concern.

Also, I would like to see the source code of this CEF published in an OnlyOffice repository, as it seems to be a modified build of the upstream CEF (Dektop Editors segfaults when trying to use an offical CEF build). Please correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants