Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP v6 #2504

Open
wants to merge 337 commits into
base: master
Choose a base branch
from
Open

WIP v6 #2504

wants to merge 337 commits into from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jul 20, 2024

Fixes #106
Closes #126
Fixes #226 (SE)
Closes #520 (SE)
Fixes #987
Fixes #1420
Closes #1641 (SE)
Fixes #1987
Fixes #2082
Fixes #2086
Fixes #2168
Fixes #2194
Fixes #2361
Fixes #2495

@tinohager
Copy link
Contributor

Is there already a time horizon for completion :) ?

@ildyria
Copy link
Member Author

ildyria commented Aug 2, 2024

I wish. :')

I have a PR here to create a small blog:
LycheeOrg/LycheeOrg.github.io#132

waiting for reviews. :)
The blog aims to provide some highlight of the work in progress on V6.

@tinohager
Copy link
Contributor

The site looks nice. The main menu item "Docs" has no content yet. If I understand correctly, this project will also replace the current project website?

@ildyria
Copy link
Member Author

ildyria commented Aug 4, 2024

No, just an update/refresher of the LycheeOrg website, nothing much there.
The make command build the full thing in dist (including the docs ;) ).

@tinohager

This comment was marked as off-topic.

@ildyria

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@opravil-jan

This comment was marked as off-topic.

@ildyria

This comment was marked as off-topic.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@ildyria
Copy link
Member Author

ildyria commented Oct 9, 2024

Yeah I need to redo a lot of the translations. :(

@tinohager

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@tinohager
Copy link
Contributor

"Upload track"
image

what should the button say at first glance I do not recognize what exactly the meaning of this button is

@tinohager
Copy link
Contributor

image
On my docker test with chrome on windows 10 i can not drag a image to this area

@ildyria
Copy link
Member Author

ildyria commented Oct 9, 2024

"Upload track" image

what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

@tinohager
Copy link
Contributor

"Upload track" image
what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

this is probably not a likely function for a standard user. I would direct this to a separate dialog where it is better described.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 71.82663% with 364 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (02e5a20) to head (a293683).
Report is 96 commits behind head on master.

Additional details and impacted files

@ildyria ildyria marked this pull request as ready for review October 16, 2024 21:29
@ildyria
Copy link
Member Author

ildyria commented Oct 16, 2024

I deem this ready for review. I will not be adding anything on top on the PR because @d7415 still needs to review it, and this needs stability. :)

@tinohager
Copy link
Contributor

Too bad then I won't report anything more 😆 🤣

@tinohager
Copy link
Contributor

tinohager commented Oct 17, 2024

As a user the menu show the "Admin" menu headline

image

@tinohager
Copy link
Contributor

Share logic not work correct. i share my album to user1 the i press share. After that i can select the same user again.

It would be great if an additional non-editable checkbox is displayed to show the user that the user has viewing rights. The checkboxes give me the feeling that I have to select at least one here, but this is not the case.

If I delete the user in the share area, I can no longer select him. I have to reload the page.

@ildyria
Copy link
Member Author

ildyria commented Oct 17, 2024

Too bad then I won't report anything more 😆 🤣

Please don't let that block you. :)
I really do appreciate your feedback.
I will most likely create another PR on top of current v6 to do the minor fixes, but I would rather keep that PR stable. :)

As a user the menu show the "Admin" menu headline

I thought I fixed that one. >_<

Share logic not work correct. i share my album to user1 the i press share. After that i can select the same user again.

Definitely a bug!

It would be great if an additional non-editable checkbox is displayed to show the user that the user has viewing rights. The checkboxes give me the feeling that I have to select at least one here, but this is not the case.

Haaaa good idea to trick the mind ! Love it :)

If I delete the user in the share area, I can no longer select him. I have to reload the page.

Noted. I will check that.

@tinohager
Copy link
Contributor

Missing error message on upload failure

image
image

@tinohager
Copy link
Contributor

Video wrong icon path "play-icon.png"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment