New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't change icons #4875

Open

AndrewDallas opened this issue Oct 3, 2024 · 5 comments · May be fixed by #4900

Labels

bug

AndrewDallas commented Oct 3, 2024

Describe the bug

Clicking on an icon to change it sends to the "home settings" instead of the icon selection page.

Steps to reproduce

Steps to reproduce the behavior:

Go to icon and long hold , click customize
Click on icon on pop up window
Sends to home settings page

Expected behavior

Should have the icon list pop up and choose icon , instead it takes me to the home settings page.

screen-20241003-081803.2.mp4

Screenshots

No response

Device information

Device: [e.g. Google Pixel 6]
OS: [e.g. stock ROM Android version 12.0]
App version: [e.g. 12.1.0 Alpha 4]

Additional context

No response

AndrewDallas added the bug label

everypizza1 commented Oct 4, 2024

I'm also experiencing this on the Pixel 8a running latest nightly build/Android 15 QPR2

mxKeaton commented Oct 4, 2024

Same here with the Poco X3 Pro, latest lawnchair nightly build, and lineageOS

FrenchToucan commented Oct 5, 2024

Same on Android 14 September patch on a Pixel 9.

RVSmooth commented Oct 11, 2024

Same experience while allowing the app notification dots

RastalDev commented Oct 11, 2024

Yep, replicating exactly the same issue on Version 14.Dev.(#1492) on Pixel 8A

Rafael2616 added a commit to Rafael2616/lawnchair that referenced this issue


          fix custom app icon dialog not showing

3da10ed

the navigation dependency version 2.8.1 breaks the current behavior used defined here https://github.com/LawnchairLauncher/lawnchair/blob/d0d19849bb5af42f203b244831f338638a43f5ad/lawnchair/src/app/lawnchair/override/CustomizeDialog.kt#L131, see: https://developer.android.com/jetpack/androidx/releases/navigation#:~:text=A%20NavDestination%20can,potentially%20protected%20destination . So this comit is an teporary fix for this while an definitive solution is not made
this commits fixes LawnchairLauncher#4875

Rafael2616 linked a pull request

that will close this issue

fix custom app icon screen not showing #4900

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment