Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe controller implementation #205

Open
shubham-shahh opened this issue Feb 11, 2022 · 5 comments
Open

Failsafe controller implementation #205

shubham-shahh opened this issue Feb 11, 2022 · 5 comments
Labels
question Further information is requested

Comments

@shubham-shahh
Copy link
Contributor

Hi,
do you have any plans of implementing Failsafe controllers? which can handle landing without a position estimate?

thanks

@Jaeyoung-Lim
Copy link
Owner

Jaeyoung-Lim commented Feb 17, 2022

@shubham-shahh The safety should come from the autopilot, and this is why we are using the offboard interface. (in case something goes wrong it should fall back to the autopilot and not using anything from the companion computer)

Therefore there are no plans as far as I am concerned. However, I would be open for suggestions if someone would contribute such a feature and it is useful. Could you explain why you would want a failsafe controller within this package?

@shubham-shahh
Copy link
Contributor Author

Hi, In case of a flight where the autopilot has no secondary sources to fallback, there is a need of a failsafe controller which can aid landing without a position estimate.
If we implement a failsafe controller in this package, mavros_controllers can be used as an end to end solution for vision based flights where there are no other sources to fallback

thanks

@Jaeyoung-Lim
Copy link
Owner

Hi, In case of a flight where the autopilot has no secondary sources to fallback, there is a need of a failsafe controller which can aid landing without a position estimate.

Not sure if I understand this correctly. The flight controller already has safety fallbacks and can safely land without position estimates. If we want a fallback policy it should be inside the flight controller and not on the companion computer since the flight controller is more reliable than the companion computer in general

@shubham-shahh
Copy link
Contributor Author

Hi, In case of a flight where the autopilot has no secondary sources to fallback, there is a need of a failsafe controller which can aid landing without a position estimate.

Not sure if I understand this correctly. The flight controller already has safety fallbacks and can safely land without position estimates. If we want a fallback policy it should be inside the flight controller and not on the companion computer since the flight controller is more reliable than the companion computer in general

Hi, for example this package implements a failsafe controller. If I am not wrong, without any external postion estimate, autopilot can only depend on dead reckoning based method for landing, and the drift is accumulated, which results in a poor landing, please correct me if I am wrong or I'm missing out on something

@Jaeyoung-Lim
Copy link
Owner

@shubham-shahh I think the dead reckoning part really doesn't change whether you have a failsafe controller outside the fmu. (which the fmu already has in the PX4 case)

@Jaeyoung-Lim Jaeyoung-Lim added the question Further information is requested label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants