Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimising data type rendering #24

Open
sunng87 opened this issue Dec 6, 2022 · 2 comments
Open

Optimising data type rendering #24

sunng87 opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sunng87
Copy link
Member

sunng87 commented Dec 6, 2022

As we have finished rendering data as table and chart, the next step is to visualize data type/table schema information.

Date types

As of https://github.com/GreptimeTeam/greptimedb/tree/v0.1.0-alpha-20221205-weekly, we have following data types supported:

  • Null (can be ignored when rendering schema)
  • Boolean
  • Numbers:
    • Int8
    • Int16
    • Int32
    • Int64
    • UInt8
    • UInt16
    • UInt32
    • UInt64
    • Float32
    • Float64
  • Strings:
    • Binary bytes (not supported for now)
    • String
  • Time and date:
    • Date
    • DateTime
    • Timestamp
  • Compound types
    • List (not well supported at the moment, ignored for now)

https://github.com/GreptimeTeam/greptimedb/blob/v0.1.0-alpha-20221205-weekly/src/datatypes/src/data_type.rs#L34

So the main types we going to render are:

  • Boolean
  • Number
  • Strings
  • Date time types

Rendering

How we are rendering these types:

  • Use icon and tooltip for table schema tree
  • Use icon and tooltip for result table row header
  • Use custom styles for result table content:
    • use special style for string, hex bytes
    • use special style for date time types, add readable tooltip for timestamps
@sunng87 sunng87 added the enhancement New feature or request label Dec 6, 2022
ZonaHex added a commit that referenced this issue Dec 8, 2022
Optimising data type rendering #24
ZonaHex added a commit that referenced this issue Dec 9, 2022
ZonaHex added a commit that referenced this issue Dec 13, 2022
Note: Don't know why svg file can't perform well

Optimising data type rendering #24
ZonaHex added a commit that referenced this issue Dec 15, 2022
Note: Don't know why svg file can't perform well

Optimising data type rendering #24
@ZonaHex
Copy link
Collaborator

ZonaHex commented Aug 8, 2023

https://docs.greptime.com/reference/data-types
We have 4 types of timestamp[(0/3/6/9)]. Probably need to address this.
Fixed by #312 for #311

@ZonaHex
Copy link
Collaborator

ZonaHex commented Aug 17, 2023

GreptimeTeam/greptimedb#2072
Follow up on this. Probably need to change time types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants