-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPL3 Time Accumulation/Coupling #3027
Comments
Notes from discussion with Tom Clune(11 Sept 2024):
|
Minor clarification. initialize() is a specific phase and is as described above. But the Action subclass will still have a constructor and that could in principle have specs (not VarSpecs) as its inputs. I don't think it should though. My naive initial thought is that the constructor would have something like |
Somehow @darianboggs reposted the original sketch rather than the updated one. I have no deleted that to avoid confusion. Sept 12 notes are shown here:
|
Need to reconcile different time steps and offsets for source and destination components |
The issue is even broader than that. "We" need to figure out how (if?) we control the offset for components that do not run on the heartbeat. In MAPL2 I think there is an implicit assumption that at 0z all components run, and maybe that is good enough. |
The "heartbeat" expresses an offset |
We want to accomodate (eventually) various cases of the heartbeats for the source, destination, and accumulation. |
I think we reserve the term "heartbeat" for the model as a whole. For the other components we just refer to their timestep. @bena-nasa please correct my terminology if I'm off. |
Update:Given a source field S, destination field D, and coupler C:
|
MAPL3 needs a module to accumulate field values in time for totals (accumulation), means (time averaging), and evaluations of functions like
max
andmin
as well as writing the results to destination fields (coupling).In MAPL2,
GenericCplComp
performs these functions, but it initializes from a list ofVarSpec's
, not ESMF_Field's. In MAPL3, it will initialize onESMF_Field's
, and it will work on grid comps.So, the module will integrate into the MAPL3 architecture.
The text was updated successfully, but these errors were encountered: