Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect variables in write_restart() #3013

Open
tclune opened this issue Sep 8, 2024 · 2 comments
Open

Incorrect variables in write_restart() #3013

tclune opened this issue Sep 8, 2024 · 2 comments
Assignees
Labels
🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related

Comments

@tclune
Copy link
Collaborator

tclune commented Sep 8, 2024

The procedure shown below is attempting to write (uninitialized) local variables states rather than the states provided as dummy arguments. (Note that I'm using ESMF camelCase for common ESMF variables rather than the MAPL usual snake_case.)

call restart_handler%write("import", import_state, _RC)
call restart_handler%write("internal", internal_state, _RC)

@tclune tclune added 🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related labels Sep 8, 2024
@tclune
Copy link
Collaborator Author

tclune commented Sep 8, 2024

Same issue with read_restart()

Found these while trying to cleanup various compiler warnings.

@pchakraborty
Copy link
Collaborator

pchakraborty commented Sep 9, 2024

The procedure shown below is attempting to write (uninitialized) local variables states rather than the states provided as dummy arguments. (Note that I'm using ESMF camelCase for common ESMF variables rather than the MAPL usual snake_case.)

call restart_handler%write("import", import_state, _RC)
call restart_handler%write("internal", internal_state, _RC)

@tclune The local variables import/internal_state are getting filled in the previous steps

call states%get_state(import_state, "import", _RC)
call states%get_state(internal_state, "internal", _RC)

For the internal state, that seems to be right way. For import state, I'm not sure why I didn't use importState input. Maybe for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

No branches or pull requests

2 participants