-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VariableSpec and StateItemSpec #2980
Labels
📈 MAPL3
MAPL 3 Related
Comments
There may be a dependency chain:
Is that correct? I can work around it, but I want to confirm:
|
I think this:
should be this:
|
Yes. Sorry. |
tclune
added a commit
that referenced
this issue
Aug 26, 2024
…_state_item_spec Feature/wdboggs/#2980 refactor state item spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For indirect reasons, it would now be preferable if subclasses of StateItemSpec have trivial constructors with an initialize() method doing more of the heavy lifting.
This could be done in two ways: (Consider FieldSpec is the poster child for StateItemSpec subclasses)
Originally I was thinking (1), but (2) has several advantages. In particular, it means that VariableSpec does not appear in the interfaces of StateItemSpec, and this may allow
make_ItemSpec()
to continue to live right where it is and require less total refactoring.For now the call to initialize() can remain inside of
make_ItemSpec()
. Moving that to a new home is something I can do when I'm ready to exercise this functionality.I will need this soon, so please be honest about level of effort you can apply.
The text was updated successfully, but these errors were encountered: