Remove cite_string ?

[TNRiley]

cite_string has no real functionality and I'm still not able to envision a need for a third custom metadata field outside of some very complex use cases. In order to keep the package clean do we want to consider removing cite_string at this point?

cite_string also poses some issues with re-uploaded data. For example, when re-uploading a .csv the tables throw errors. This is probably an easy fix (I think shifting the output from unknown to NA).

I'm not sure about the work it would take to add cite_string back in later if it was determined to be a useful addition or the work/potential issues we might run into by removing at this point. Maybe just removing it from the shiny?

Thoughts?
@LukasWallrich @DrMattG @rootsandberries @kaitlynhair

[LukasWallrich]

We had that discussion a couple of times already - to me, it would seem quite intuitive to want to separate databases, screening stages and search strings, but that might just be me. I would suggest at least keeping it in the R package, where most users can easily ignore it, and removing it from the Shiny app, if you feel it causes clutter and potential confusion there - but happy to go with any decision.

[LukasWallrich]

One discussion was here - though the original reason for removing it (an ASySD limitation) is gone: #123

[TNRiley]

One discussion was here - though the original reason for removing it (an ASySD limitation) is gone: #123

thanks for reminding me of this discussion and for your input. Keeping it sounds like the best decision. If there are any specific items that need to be cleaned up on the shiny end of things we can add those as individual issues.