Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated openslide v4.0.0 #368

Open
jacob-rosenthal opened this issue Oct 16, 2023 · 1 comment
Open

Use updated openslide v4.0.0 #368

jacob-rosenthal opened this issue Oct 16, 2023 · 1 comment
Assignees
@jamesgwen
Labels
dependencies Pull requests that update a dependency file

Comments

@jacob-rosenthal
Copy link
Collaborator

A new version of openslide was recently released with some improvements, notably support for DICOM. Maybe pathml support for DICOM could be moved to use openslide instead of the backend we currently have in place

https://github.com/openslide/openslide/releases/tag/v4.0.0
@jamesgwen jamesgwen self-assigned this Oct 17, 2023
@jamesgwen jamesgwen added the dependencies Pull requests that update a dependency file label Oct 17, 2023
@jamesgwen
Copy link
Collaborator

jamesgwen commented Oct 17, 2023 •
edited
Loading

Notes:

  • v4.0.0 corresponds to v1.3.0 in openslide-python

  • Check if v.1.3.0 or above works with existing code, change if necessary

  • Explore and potentially update DICOM backend

@jamesgwen jamesgwen mentioned this issue Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesgwen jamesgwen

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

update-openslide-v4 Dana-Farber-AIOS/pathml
2 participants
@jacob-rosenthal @jamesgwen