Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Loop Block: Jetpack Comments iframe has inconsistent height #92671

Open
sajmes opened this issue Jul 14, 2024 · 7 comments · May be fixed by Automattic/jetpack#39791
Open

Query Loop Block: Jetpack Comments iframe has inconsistent height #92671

sajmes opened this issue Jul 14, 2024 · 7 comments · May be fixed by Automattic/jetpack#39791
Assignees
@agrullon95
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug

Comments

@sajmes
Copy link

sajmes commented Jul 14, 2024 •
edited
Loading

Quick summary

The Jetpack comments form uses an iframe. When used in a Query Loop Block post template, the initial comments form has a smaller height than all subsequent comments forms in the Query Loop Block.

I tested on both Zoologist and Twenty Twenty-Four.

Steps to reproduce

  1. Add a Query Loop block.
  2. Add a comment section at the bottom of the post template within the Query Loop Block.

What you expected to happen

The spacing will be consistent across all posts displayed within the template.

What actually happened

The initial comment section has a smaller height than the subsequent blocks. For example, on both a user's site and my test site, the initial iframe has a height of 170px while the later iframes are 430px. This causes an inconsistent display of posts.

CleanShot 2024-07-14 at 14 01 37

CleanShot 2024-07-14 at 14 02 06

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform

Atomic

Logs or notes

User report: 8481379-zd-a8c
@sajmes sajmes added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Jul 14, 2024
@retnonindya
Copy link

📌 REPRODUCTION RESULTS
Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO
I can't even see the comment block on my test page. A bit of note: My test site is Simple (Premium), and I created a new template (titled "Blog List) with Query Loop Block in it and added Comments Block as guided by this report. I assigned the template on a page, and when I checked the live page, I can't see the comment form.

Screenshot 2024-08-15 at 2 57 08 PM

I used TT4 as guided.

📌 ACTIONS
In Triage. I'm yet to determine if this is expected (Comments Block no longer work when it's inside Query Loop Block or Post Template Block) or if this is a bug.

@github-actions GitHub Actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 8481379-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 15, 2024
@retnonindya retnonindya removed the Needs triage Ticket needs to be triaged label Aug 15, 2024
@retnonindya
Copy link

I still can't see comment block that added inside Query Loop Block. I'm checking with GB folks here: p1724229365102759-slack-CBTN58FTJ

@ntsekouras
Copy link
Member

👋 I quickly tested in GB trunk and there doesn't seem to be a problem..
Screenshot 2024-08-22 at 10 31 37 AM

The issue mentions Jetpack comments.. Is there a different Jetpack block? Additionally I don't believe the core comments block renders an iframe..

@sajmes
Copy link
Author

sajmes commented Aug 31, 2024 •
edited
Loading

Updating this thread with this comment from @tyxla:

looks like a Jetpack comments issue indeed. it could be in verbum, which I think is shipped with wpcomsh (jetpack-mu-wpcom nowadays). might need the full puzzle (an atomic site for example) to be able to repro it.

The comments on my test site do reference Verbum, and both the user's site and my test site are Atomic on Dotcom.

V

@inaikem
Copy link
Contributor

inaikem commented Oct 15, 2024

Not 100% sure why this is still "In Triage". It looks like we have a good handle on where the issue is coming from (Verbum). @Automattic/vertex, can you please review as part of ongoing/continuous maintenance?

@agrullon95
Copy link
Contributor

@inaikem - Thanks for the team ping (Vertex). I'll look into this issue today.

@agrullon95 agrullon95 self-assigned this Oct 15, 2024
@agrullon95 agrullon95 linked a pull request Oct 16, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrullon95 agrullon95

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug
Projects
Automattic Prioritization: The One Board ™
Status: Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verbum Comments: Fix iframe resize logic Automattic/jetpack
5 participants
@agrullon95 @ntsekouras @retnonindya @inaikem @sajmes